ISSUE-316 Fix caching for CNAME and DNAME #320
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is a WIP, I tried to come up with a test, but don't know the internals well enough atm to do so. I did manually test for my use case and it does seem to be caching responses, but haven't verified TTLs are handled to spec.
|
|
Hi, sorry for not reacting earlier and thanks for your effort. |
ibauersachs
added a commit
that referenced
this pull request
Jul 27, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a WIP for #316 , I tried to come up with a test, but don't know the internals well enough atm to do so yet. I did manually test for my use case and it does seem to be caching responses, but haven't verified TTLs are handled to spec.